diff options
| author | Josh Triplett <josh@joshtriplett.org> | 2020-03-28 14:54:01 -0700 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-03-28 23:11:39 -0400 |
| commit | df41460a21b06a76437af040d90ccee03888e8e5 (patch) | |
| tree | b53555b81714ec64324470ef3b75b55a93557b49 /fs/ext4/super.c | |
| parent | b9c538da4e52a7b79dfcf4cfa487c46125066dfb (diff) | |
| download | lwn-df41460a21b06a76437af040d90ccee03888e8e5.tar.gz lwn-df41460a21b06a76437af040d90ccee03888e8e5.zip | |
ext4: fix incorrect group count in ext4_fill_super error message
ext4_fill_super doublechecks the number of groups before mounting; if
that check fails, the resulting error message prints the group count
from the ext4_sb_info sbi, which hasn't been set yet. Print the freshly
computed group count instead (which at that point has just been computed
in "blocks_count").
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Fixes: 4ec1102813798 ("ext4: Add sanity checks for the superblock before mounting the filesystem")
Link: https://lore.kernel.org/r/8b957cd1513fcc4550fe675c10bcce2175c33a49.1585431964.git.josh@joshtriplett.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/super.c')
| -rw-r--r-- | fs/ext4/super.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 2837f27947f9..0153ae330c86 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4305,9 +4305,9 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) EXT4_BLOCKS_PER_GROUP(sb) - 1); do_div(blocks_count, EXT4_BLOCKS_PER_GROUP(sb)); if (blocks_count > ((uint64_t)1<<32) - EXT4_DESC_PER_BLOCK(sb)) { - ext4_msg(sb, KERN_WARNING, "groups count too large: %u " + ext4_msg(sb, KERN_WARNING, "groups count too large: %llu " "(block count %llu, first data block %u, " - "blocks per group %lu)", sbi->s_groups_count, + "blocks per group %lu)", blocks_count, ext4_blocks_count(es), le32_to_cpu(es->s_first_data_block), EXT4_BLOCKS_PER_GROUP(sb)); |