diff options
author | Eric Gouriou <egouriou@google.com> | 2011-10-27 11:43:23 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2011-10-27 11:43:23 -0400 |
commit | 6f91bc5fda82d2c49b4f7fb29424cf6a3c7574bc (patch) | |
tree | e5670070f007c4ad5300e93a4e36fa9a802e2bd9 /fs/ext4/super.c | |
parent | 446066724c3629664e29942a00b0aee0d6b1663a (diff) | |
download | lwn-6f91bc5fda82d2c49b4f7fb29424cf6a3c7574bc.tar.gz lwn-6f91bc5fda82d2c49b4f7fb29424cf6a3c7574bc.zip |
ext4: optimize ext4_ext_convert_to_initialized()
This patch introduces a fast path in ext4_ext_convert_to_initialized()
for the case when the conversion can be performed by transferring
the newly initialized blocks from the uninitialized extent into
an adjacent initialized extent. Doing so removes the expensive
invocations of memmove() which occur during extent insertion and
the subsequent merge.
In practice this should be the common case for clients performing
append writes into files pre-allocated via
fallocate(FALLOC_FL_KEEP_SIZE). In such a workload performed via
direct IO and when using a suboptimal implementation of memmove()
(x86_64 prior to the 2.6.39 rewrite), this patch reduces kernel CPU
consumption by 32%.
Two new trace points are added to ext4_ext_convert_to_initialized()
to offer visibility into its operations. No exit trace point has
been added due to the multiplicity of return points. This can be
revisited once the upstream cleanup is backported.
Signed-off-by: Eric Gouriou <egouriou@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/super.c')
-rw-r--r-- | fs/ext4/super.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index dcc460537bc7..9953d80145ad 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -45,6 +45,7 @@ #include <linux/freezer.h> #include "ext4.h" +#include "ext4_extents.h" #include "ext4_jbd2.h" #include "xattr.h" #include "acl.h" |