summaryrefslogtreecommitdiff
path: root/fs/ext4/resize.c
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2018-11-03 17:11:19 -0400
committerTheodore Ts'o <tytso@mit.edu>2018-11-03 17:11:19 -0400
commitea0abbb648452cdb6e1734b702b6330a7448fcf8 (patch)
tree365b3f1ad3d6c576649cfafdfbdb384d8ab1e9cf /fs/ext4/resize.c
parent61a9c11e5e7a0dab5381afa5d9d4dd5ebf18f7a0 (diff)
downloadlwn-ea0abbb648452cdb6e1734b702b6330a7448fcf8.tar.gz
lwn-ea0abbb648452cdb6e1734b702b6330a7448fcf8.zip
ext4: add missing brelse() update_backups()'s error path
Fixes: ac27a0ec112a ("ext4: initial copy of files from ext3") Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org # 2.6.19
Diffstat (limited to 'fs/ext4/resize.c')
-rw-r--r--fs/ext4/resize.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 7131f35b62d9..3df326ee6d50 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1121,8 +1121,10 @@ static void update_backups(struct super_block *sb, sector_t blk_off, char *data,
backup_block, backup_block -
ext4_group_first_block_no(sb, group));
BUFFER_TRACE(bh, "get_write_access");
- if ((err = ext4_journal_get_write_access(handle, bh)))
+ if ((err = ext4_journal_get_write_access(handle, bh))) {
+ brelse(bh);
break;
+ }
lock_buffer(bh);
memcpy(bh->b_data, data, size);
if (rest)