diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2018-11-03 16:50:08 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2018-11-03 16:50:08 -0400 |
| commit | 61a9c11e5e7a0dab5381afa5d9d4dd5ebf18f7a0 (patch) | |
| tree | 1bf9ea20e88101c2db892bb8e2e68b28b79db2e9 /fs/ext4/resize.c | |
| parent | cea5794122125bf67559906a0762186cf417099c (diff) | |
| download | lwn-61a9c11e5e7a0dab5381afa5d9d4dd5ebf18f7a0.tar.gz lwn-61a9c11e5e7a0dab5381afa5d9d4dd5ebf18f7a0.zip | |
ext4: add missing brelse() add_new_gdb_meta_bg()'s error path
Fixes: 01f795f9e0d6 ("ext4: add online resizing support for meta_bg ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 3.7
Diffstat (limited to 'fs/ext4/resize.c')
| -rw-r--r-- | fs/ext4/resize.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 0a4dc6217e78..7131f35b62d9 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -922,6 +922,7 @@ static int add_new_gdb_meta_bg(struct super_block *sb, sizeof(struct buffer_head *), GFP_NOFS); if (!n_group_desc) { + brelse(gdb_bh); err = -ENOMEM; ext4_warning(sb, "not enough memory for %lu groups", gdb_num + 1); @@ -937,8 +938,6 @@ static int add_new_gdb_meta_bg(struct super_block *sb, kvfree(o_group_desc); BUFFER_TRACE(gdb_bh, "get_write_access"); err = ext4_journal_get_write_access(handle, gdb_bh); - if (unlikely(err)) - brelse(gdb_bh); return err; } |