summaryrefslogtreecommitdiff
path: root/fs/ext4/namei.c
diff options
context:
space:
mode:
authorGuo Chao <yan@linux.vnet.ibm.com>2013-01-28 21:41:02 -0500
committerTheodore Ts'o <tytso@mit.edu>2013-01-28 21:41:02 -0500
commitb1deefc99e668348f7c785c6ece5f6ff4c6d8b5c (patch)
treece16d0377ace3dfd7c0a4ecefc27f29a8ee431c2 /fs/ext4/namei.c
parent41be871f747f64e076b09a68ae82a643e2ffb215 (diff)
downloadlwn-b1deefc99e668348f7c785c6ece5f6ff4c6d8b5c.tar.gz
lwn-b1deefc99e668348f7c785c6ece5f6ff4c6d8b5c.zip
ext4: remove unnecessary NULL pointer check
brelse() and ext4_journal_force_commit() are both inlined and able to handle NULL. Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/namei.c')
-rw-r--r--fs/ext4/namei.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index f4b95870870e..34ed624d2c56 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2110,8 +2110,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry,
journal_error:
ext4_std_error(dir->i_sb, err);
cleanup:
- if (bh)
- brelse(bh);
+ brelse(bh);
dx_release(frames);
return err;
}