diff options
| author | Robin Dong <hao.bigrat@gmail.com> | 2011-05-05 10:44:04 +0800 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2011-05-17 13:47:42 +0200 |
| commit | 4e299c1d9113b5c1c3845c0d4e78d09dd60a4fe8 (patch) | |
| tree | 24d209ff8fe59ec0e43fd88be35f45bd687bc975 /fs/ext2/super.c | |
| parent | d9b01934d56a96d9f4ae2d6204d4ea78a36f5f36 (diff) | |
| download | lwn-4e299c1d9113b5c1c3845c0d4e78d09dd60a4fe8.tar.gz lwn-4e299c1d9113b5c1c3845c0d4e78d09dd60a4fe8.zip | |
ext2: fix error msg when mounting fs with too-large blocksize
When ext2 mounts a filesystem, it attempts to set the block device
blocksize with a call to sb_set_blocksize, which can fail for
several reasons. The current failure message in ext2 prints:
EXT2-fs (loop1): error: blocksize is too small
which is not correct in all cases. This can be demonstrated
by creating a filesystem with
# mkfs.ext2 -b 8192
on a 4k page system, and attempting to mount it.
Change the error message to a more generic:
EXT2-fs (loop1): bad blocksize 8192
to match the error message in ext3.
Signed-off-by: Robin Dong <sanbai@taobao.com>
Reviewed-by: Coly Li <bosong.ly@taobao.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext2/super.c')
| -rw-r--r-- | fs/ext2/super.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 0a78dae7e2cb..1dd62ed35b85 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -898,7 +898,8 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) brelse(bh); if (!sb_set_blocksize(sb, blocksize)) { - ext2_msg(sb, KERN_ERR, "error: blocksize is too small"); + ext2_msg(sb, KERN_ERR, + "error: bad blocksize %d", blocksize); goto failed_sbi; } |