diff options
author | Mike Snitzer <snitzer@redhat.com> | 2016-05-05 11:54:21 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2016-05-05 13:03:26 -0600 |
commit | bbd848e0fade51ae51dab86a0683069cef89953f (patch) | |
tree | 1f3a5d8107fe664a19ebddf4f656b0f50fe267b5 /fs/exportfs | |
parent | a21f2a3ec62abe2e06500d6550659a0ff5624fbb (diff) | |
download | lwn-bbd848e0fade51ae51dab86a0683069cef89953f.tar.gz lwn-bbd848e0fade51ae51dab86a0683069cef89953f.zip |
block: reinstate early return of -EOPNOTSUPP from blkdev_issue_discard
Commit 38f25255330 ("block: add __blkdev_issue_discard") incorrectly
disallowed the early return of -EOPNOTSUPP if the device doesn't support
discard (or secure discard). This early return of -EOPNOTSUPP has
always been part of blkdev_issue_discard() interface so there isn't a
good reason to break that behaviour -- especially when it can be easily
reinstated.
The nuance of allowing early return of -EOPNOTSUPP vs disallowing late
return of -EOPNOTSUPP is: if the overall device never advertised support
for discards and one is issued to the device it is beneficial to inform
the caller that discards are not supported via -EOPNOTSUPP. But if a
device advertises discard support it means that at least a subset of the
device does have discard support -- but it could be that discards issued
to some regions of a stacked device will not be supported. In that case
the late return of -EOPNOTSUPP must be disallowed.
Fixes: 38f25255330 ("block: add __blkdev_issue_discard")
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'fs/exportfs')
0 files changed, 0 insertions, 0 deletions