diff options
| author | hyeongseok.kim <hyeongseok@gmail.com> | 2020-06-04 13:54:28 +0900 |
|---|---|---|
| committer | Namjae Jeon <namjae.jeon@samsung.com> | 2020-06-09 16:50:12 +0900 |
| commit | a949824f01f3b39f737d77aed6cba47aced09319 (patch) | |
| tree | 6a4a0a18ef24d58c8488e50c633df8dbbabf3078 /fs/exfat | |
| parent | 29bbb14bfc80dd760b07d2be0a27e610562982e3 (diff) | |
| download | lwn-a949824f01f3b39f737d77aed6cba47aced09319.tar.gz lwn-a949824f01f3b39f737d77aed6cba47aced09319.zip | |
exfat: fix range validation error in alloc and free cluster
There is check error in range condition that can never be entered
even with invalid input.
Replace incorrent checking code with already existing valid checker.
Signed-off-by: hyeongseok.kim <hyeongseok@gmail.com>
Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Diffstat (limited to 'fs/exfat')
| -rw-r--r-- | fs/exfat/fatent.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/exfat/fatent.c b/fs/exfat/fatent.c index 267e5e09eb13..4e5c5c9c0f2d 100644 --- a/fs/exfat/fatent.c +++ b/fs/exfat/fatent.c @@ -169,7 +169,7 @@ int exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain) return 0; /* check cluster validation */ - if (p_chain->dir < 2 && p_chain->dir >= sbi->num_clusters) { + if (!is_valid_cluster(sbi, p_chain->dir)) { exfat_err(sb, "invalid start cluster (%u)", p_chain->dir); return -EIO; } @@ -346,7 +346,7 @@ int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc, } /* check cluster validation */ - if (hint_clu < EXFAT_FIRST_CLUSTER && hint_clu >= sbi->num_clusters) { + if (!is_valid_cluster(sbi, hint_clu)) { exfat_err(sb, "hint_cluster is invalid (%u)", hint_clu); hint_clu = EXFAT_FIRST_CLUSTER; |