diff options
| author | Kees Cook <keescook@chromium.org> | 2022-11-17 16:31:55 -0800 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2022-11-17 16:31:55 -0800 |
| commit | cd57e443831d8eeb083c7165bce195d886e216d4 (patch) | |
| tree | 723c6ae9e26f2f1b1efdb6c25ac9ccadb56229f3 /fs/exec.c | |
| parent | dc64cc12bcd14219afb91b55d23192c3eb45aa43 (diff) | |
| download | lwn-cd57e443831d8eeb083c7165bce195d886e216d4.tar.gz lwn-cd57e443831d8eeb083c7165bce195d886e216d4.zip | |
exec: Remove FOLL_FORCE for stack setup
It does not appear that FOLL_FORCE should be needed for setting up the
stack pages. They are allocated using the nascent brpm->vma, which was
newly created with VM_STACK_FLAGS, which an arch can override, but they
all appear to include VM_WRITE | VM_MAYWRITE. Remove FOLL_FORCE.
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org
Link: https://lore.kernel.org/lkml/202211171439.CDE720EAD@keescook/
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'fs/exec.c')
| -rw-r--r-- | fs/exec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/exec.c b/fs/exec.c index 9585bc1bc970..870a707b5d3b 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -200,7 +200,7 @@ static struct page *get_arg_page(struct linux_binprm *bprm, unsigned long pos, { struct page *page; int ret; - unsigned int gup_flags = FOLL_FORCE; + unsigned int gup_flags = 0; #ifdef CONFIG_STACK_GROWSUP if (write) { |