diff options
| author | Ross Lagerwall <ross.lagerwall@citrix.com> | 2015-04-02 08:39:00 +0100 |
|---|---|---|
| committer | Matt Fleming <matt.fleming@intel.com> | 2015-04-17 15:41:13 +0100 |
| commit | c57dcb566d3d866a302a1da2e06344bec31d5bcd (patch) | |
| tree | dcfff9f237c2d3d6d82ccecbeee230f1756119ce /fs/efivarfs | |
| parent | bfbaafae8519d82d10da6abe75f5766dd5b20475 (diff) | |
| download | lwn-c57dcb566d3d866a302a1da2e06344bec31d5bcd.tar.gz lwn-c57dcb566d3d866a302a1da2e06344bec31d5bcd.zip | |
efivarfs: Ensure VariableName is NUL-terminated
Some buggy firmware implementations update VariableNameSize on success
such that it does not include the final NUL character which results in
garbage in the efivarfs name entries. Use kzalloc on the efivar_entry
(as is done in efivars.c) to ensure that the name is always
NUL-terminated.
The buggy firmware is:
BIOS Information
Vendor: Intel Corp.
Version: S1200RP.86B.02.02.0005.102320140911
Release Date: 10/23/2014
BIOS Revision: 4.6
System Information
Manufacturer: Intel Corporation
Product Name: S1200RP_SE
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Matthew Garrett <mjg59@coreos.com>
Cc: Jeremy Kerr <jk@ozlabs.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'fs/efivarfs')
| -rw-r--r-- | fs/efivarfs/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c index ddbce42548c9..acf9a67f6770 100644 --- a/fs/efivarfs/super.c +++ b/fs/efivarfs/super.c @@ -121,7 +121,7 @@ static int efivarfs_callback(efi_char16_t *name16, efi_guid_t vendor, int len, i; int err = -ENOMEM; - entry = kmalloc(sizeof(*entry), GFP_KERNEL); + entry = kzalloc(sizeof(*entry), GFP_KERNEL); if (!entry) return err; |