diff options
| author | Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2015-08-11 19:22:25 -0300 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2015-08-17 16:22:21 -0500 |
| commit | 00dcffaebf7b4ab0524c56694c22de6b0eb22feb (patch) | |
| tree | aa30d58d5a2a9616c09f6ec289c9c967568e67a3 /fs/dlm | |
| parent | acee4e527d5f069351f835602b23602d01de5e1f (diff) | |
| download | lwn-00dcffaebf7b4ab0524c56694c22de6b0eb22feb.tar.gz lwn-00dcffaebf7b4ab0524c56694c22de6b0eb22feb.zip | |
dlm: fix reconnecting but not sending data
There are cases on which lowcomms_connect_sock() is called directly,
which caused the CF_WRITE_PENDING flag to not bet set upon reconnect,
specially on send_to_sock() error handling. On this last, the flag was
already cleared and no further attempt on transmitting would be done.
As dlm tends to connect when it needs to transmit something, it makes
sense to always mark this flag right after the connect.
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Diffstat (limited to 'fs/dlm')
| -rw-r--r-- | fs/dlm/lowcomms.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 4ea64e93e6b1..cd008c94efb8 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1020,6 +1020,7 @@ socket_err: out: mutex_unlock(&con->sock_mutex); + set_bit(CF_WRITE_PENDING, &con->flags); } /* Connect a new socket to its peer */ @@ -1114,6 +1115,7 @@ out_err: } out: mutex_unlock(&con->sock_mutex); + set_bit(CF_WRITE_PENDING, &con->flags); return; } @@ -1502,10 +1504,8 @@ static void process_send_sockets(struct work_struct *work) { struct connection *con = container_of(work, struct connection, swork); - if (test_and_clear_bit(CF_CONNECT_PENDING, &con->flags)) { + if (test_and_clear_bit(CF_CONNECT_PENDING, &con->flags)) con->connect_action(con); - set_bit(CF_WRITE_PENDING, &con->flags); - } if (test_and_clear_bit(CF_WRITE_PENDING, &con->flags)) send_to_sock(con); } |