diff options
| author | David Teigland <teigland@redhat.com> | 2009-11-30 16:34:43 -0600 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2009-11-30 16:34:43 -0600 |
| commit | 573c24c4af6664ffcd9aa7ba617a35fde2b95534 (patch) | |
| tree | 9222c0c8921fda5b842c2d1007d911d47bd4fe7c /fs/dlm/rcom.c | |
| parent | a8a8a669ea13d792296737505adc43ccacf3a648 (diff) | |
| download | lwn-573c24c4af6664ffcd9aa7ba617a35fde2b95534.tar.gz lwn-573c24c4af6664ffcd9aa7ba617a35fde2b95534.zip | |
dlm: always use GFP_NOFS
Replace all GFP_KERNEL and ls_allocation with GFP_NOFS.
ls_allocation would be GFP_KERNEL for userland lockspaces
and GFP_NOFS for file system lockspaces.
It was discovered that any lockspaces on the system can
affect all others by triggering memory reclaim in the
file system which could in turn call back into the dlm
to acquire locks, deadlocking dlm threads that were
shared by all lockspaces, like dlm_recv.
Signed-off-by: David Teigland <teigland@redhat.com>
Diffstat (limited to 'fs/dlm/rcom.c')
| -rw-r--r-- | fs/dlm/rcom.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c index 67522c268c14..3c83a49a48a3 100644 --- a/fs/dlm/rcom.c +++ b/fs/dlm/rcom.c @@ -38,7 +38,7 @@ static int create_rcom(struct dlm_ls *ls, int to_nodeid, int type, int len, char *mb; int mb_len = sizeof(struct dlm_rcom) + len; - mh = dlm_lowcomms_get_buffer(to_nodeid, mb_len, ls->ls_allocation, &mb); + mh = dlm_lowcomms_get_buffer(to_nodeid, mb_len, GFP_NOFS, &mb); if (!mh) { log_print("create_rcom to %d type %d len %d ENOBUFS", to_nodeid, type, len); |