diff options
author | Miklos Szeredi <mszeredi@suse.cz> | 2014-09-24 17:56:17 +0200 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2014-09-26 21:16:42 -0400 |
commit | b928095b0a7cff7fb9fcf4c706348ceb8ab2c295 (patch) | |
tree | 3fb6e68aabf7f0fbb9a28be6423942311c67cee0 /fs/direct-io.c | |
parent | 0f33be009b89d2268e94194dc4fd01a7851b6d51 (diff) | |
download | lwn-b928095b0a7cff7fb9fcf4c706348ceb8ab2c295.tar.gz lwn-b928095b0a7cff7fb9fcf4c706348ceb8ab2c295.zip |
shmem: fix nlink for rename overwrite directory
If overwriting an empty directory with rename, then need to drop the extra
nlink.
Test prog:
#include <stdio.h>
#include <fcntl.h>
#include <err.h>
#include <sys/stat.h>
int main(void)
{
const char *test_dir1 = "test-dir1";
const char *test_dir2 = "test-dir2";
int res;
int fd;
struct stat statbuf;
res = mkdir(test_dir1, 0777);
if (res == -1)
err(1, "mkdir(\"%s\")", test_dir1);
res = mkdir(test_dir2, 0777);
if (res == -1)
err(1, "mkdir(\"%s\")", test_dir2);
fd = open(test_dir2, O_RDONLY);
if (fd == -1)
err(1, "open(\"%s\")", test_dir2);
res = rename(test_dir1, test_dir2);
if (res == -1)
err(1, "rename(\"%s\", \"%s\")", test_dir1, test_dir2);
res = fstat(fd, &statbuf);
if (res == -1)
err(1, "fstat(%i)", fd);
if (statbuf.st_nlink != 0) {
fprintf(stderr, "nlink is %lu, should be 0\n", statbuf.st_nlink);
return 1;
}
return 0;
}
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/direct-io.c')
0 files changed, 0 insertions, 0 deletions