diff options
| author | Mateusz Guzik <mjguzik@gmail.com> | 2024-06-02 14:37:19 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-06-03 15:45:47 +0200 |
| commit | 54018131e663a1df05021fcb22a18d6c5ebef734 (patch) | |
| tree | bdece4a7a68ca7e941b0e5c63112855b5c2cf637 /fs/dcache.c | |
| parent | 620c266f394932e5decc4b34683a75dfc59dc2f4 (diff) | |
| download | lwn-54018131e663a1df05021fcb22a18d6c5ebef734.tar.gz lwn-54018131e663a1df05021fcb22a18d6c5ebef734.zip | |
vfs: replace WARN(down_read_trylock, ...) abuse with proper asserts
Note the macro used here works regardless of LOCKDEP.
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20240602123720.775702-1-mjguzik@gmail.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/dcache.c')
| -rw-r--r-- | fs/dcache.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dcache.c b/fs/dcache.c index 1ee6404b430b..58b89c9e9b0c 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1548,7 +1548,7 @@ void shrink_dcache_for_umount(struct super_block *sb) { struct dentry *dentry; - WARN(down_read_trylock(&sb->s_umount), "s_umount should've been locked"); + rwsem_assert_held_write(&sb->s_umount); dentry = sb->s_root; sb->s_root = NULL; |