diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2018-08-06 09:03:58 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2018-08-06 09:13:32 -0400 |
| commit | 90bad5e05bcdb0308cfa3d3a60f5c0b9c8e2efb3 (patch) | |
| tree | 4c7687f8ce7a84e659596b6dfaeee36e8d53ef7f /fs/dcache.c | |
| parent | 9ba546c01976a426292af99e682a557075d6c010 (diff) | |
| download | lwn-90bad5e05bcdb0308cfa3d3a60f5c0b9c8e2efb3.tar.gz lwn-90bad5e05bcdb0308cfa3d3a60f5c0b9c8e2efb3.zip | |
root dentries need RCU-delayed freeing
Since mountpoint crossing can happen without leaving lazy mode,
root dentries do need the same protection against having their
memory freed without RCU delay as everything else in the tree.
It's partially hidden by RCU delay between detaching from the
mount tree and dropping the vfsmount reference, but the starting
point of pathwalk can be on an already detached mount, in which
case umount-caused RCU delay has already passed by the time the
lazy pathwalk grabs rcu_read_lock(). If the starting point
happens to be at the root of that vfsmount *and* that vfsmount
covers the entire filesystem, we get trouble.
Fixes: 48a066e72d97 ("RCU'd vsfmounts")
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/dcache.c')
| -rw-r--r-- | fs/dcache.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/dcache.c b/fs/dcache.c index 0e8e5de3c48a..d677290b0aca 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1932,10 +1932,12 @@ struct dentry *d_make_root(struct inode *root_inode) if (root_inode) { res = d_alloc_anon(root_inode->i_sb); - if (res) + if (res) { + res->d_flags |= DCACHE_RCUACCESS; d_instantiate(res, root_inode); - else + } else { iput(root_inode); + } } return res; } |