diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2024-10-03 08:09:32 -0700 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-10-07 13:51:47 +0200 |
| commit | 95472274b6fed8f2d30fbdda304e12174b3d4099 (patch) | |
| tree | baef0f83a6c5a896d1c3bb875592bcf86f4cf166 /fs/dax.c | |
| parent | 6ef6a0e821d3dad6bf8a5d5508762dba9042c84b (diff) | |
| download | lwn-95472274b6fed8f2d30fbdda304e12174b3d4099.tar.gz lwn-95472274b6fed8f2d30fbdda304e12174b3d4099.zip | |
fsdax: remove zeroing code from dax_unshare_iter
Remove the code in dax_unshare_iter that zeroes the destination memory
because it's not necessary.
If srcmap is unwritten, we don't have to do anything because that
unwritten extent came from the regular file mapping, and unwritten
extents cannot be shared. The same applies to holes.
Furthermore, zeroing to unshare a mapping is just plain wrong because
unsharing means copy on write, and we should be copying data.
This is effectively a revert of commit 13dd4e04625f ("fsdax: unshare:
zero destination if srcmap is HOLE or UNWRITTEN")
Cc: ruansy.fnst@fujitsu.com
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Link: https://lore.kernel.org/r/172796813311.1131942.16033376284752798632.stgit@frogsfrogsfrogs
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/dax.c')
| -rw-r--r-- | fs/dax.c | 8 |
1 files changed, 0 insertions, 8 deletions
@@ -1276,14 +1276,6 @@ static s64 dax_unshare_iter(struct iomap_iter *iter) if (ret < 0) goto out_unlock; - /* zero the distance if srcmap is HOLE or UNWRITTEN */ - if (srcmap->flags & IOMAP_F_SHARED || srcmap->type == IOMAP_UNWRITTEN) { - memset(daddr, 0, length); - dax_flush(iomap->dax_dev, daddr, length); - ret = length; - goto out_unlock; - } - ret = dax_iomap_direct_access(srcmap, pos, length, &saddr, NULL); if (ret < 0) goto out_unlock; |