diff options
| author | Eric Biggers <ebiggers@google.com> | 2023-03-20 16:39:43 -0700 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2023-03-27 21:15:50 -0700 |
| commit | 41b2ad80fdcaafd42fce173cb95847d0cd8614c2 (patch) | |
| tree | 633980d206be0ae2ce7215bd46207b0a5a1cf02e /fs/crypto/hkdf.c | |
| parent | 6f2656eab290f0dd437cd4b2ec956c3519172d3b (diff) | |
| download | lwn-41b2ad80fdcaafd42fce173cb95847d0cd8614c2.tar.gz lwn-41b2ad80fdcaafd42fce173cb95847d0cd8614c2.zip | |
fscrypt: use WARN_ON_ONCE instead of WARN_ON
As per Linus's suggestion
(https://lore.kernel.org/r/CAHk-=whefxRGyNGzCzG6BVeM=5vnvgb-XhSeFJVxJyAxAF8XRA@mail.gmail.com),
use WARN_ON_ONCE instead of WARN_ON. This barely adds any extra
overhead, and it makes it so that if any of these ever becomes reachable
(they shouldn't, but that's the point), the logs can't be flooded.
Link: https://lore.kernel.org/r/20230320233943.73600-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'fs/crypto/hkdf.c')
| -rw-r--r-- | fs/crypto/hkdf.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/crypto/hkdf.c b/fs/crypto/hkdf.c index 7607d18b35fc..5a384dad2c72 100644 --- a/fs/crypto/hkdf.c +++ b/fs/crypto/hkdf.c @@ -79,7 +79,7 @@ int fscrypt_init_hkdf(struct fscrypt_hkdf *hkdf, const u8 *master_key, return PTR_ERR(hmac_tfm); } - if (WARN_ON(crypto_shash_digestsize(hmac_tfm) != sizeof(prk))) { + if (WARN_ON_ONCE(crypto_shash_digestsize(hmac_tfm) != sizeof(prk))) { err = -EINVAL; goto err_free_tfm; } @@ -125,7 +125,7 @@ int fscrypt_hkdf_expand(const struct fscrypt_hkdf *hkdf, u8 context, u8 counter = 1; u8 tmp[HKDF_HASHLEN]; - if (WARN_ON(okmlen > 255 * HKDF_HASHLEN)) + if (WARN_ON_ONCE(okmlen > 255 * HKDF_HASHLEN)) return -EINVAL; desc->tfm = hkdf->hmac_tfm; |