diff options
| author | Pavel Shilovsky <pshilovsky@samba.org> | 2014-06-27 10:33:11 +0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-09-17 17:06:53 +0200 |
| commit | 98bbdfdb93af137f5364dddff5286633644cc9d1 (patch) | |
| tree | 9677be8405af52808d3d79ee7ea81ea11ac3f7f1 /fs/cifs | |
| parent | 7aadcce63d6b631f92bb2b8ff5eb8e284be81708 (diff) | |
| download | lwn-98bbdfdb93af137f5364dddff5286633644cc9d1.tar.gz lwn-98bbdfdb93af137f5364dddff5286633644cc9d1.zip | |
CIFS: Fix async reading on reconnects
commit 038bc961c31b070269ecd07349a7ee2e839d4fec upstream.
If we get into read_into_pages() from cifs_readv_receive() and then
loose a network, we issue cifs_reconnect that moves all mids to
a private list and issue their callbacks. The callback of the async
read request sets a mid to retry, frees it and wakes up a process
that waits on the rdata completion.
After the connection is established we return from read_into_pages()
with a short read, use the mid that was freed before and try to read
the remaining data from the a newly created socket. Both actions are
not what we want to do. In reconnect cases (-EAGAIN) we should not
mask off the error with a short read but should return the error
code instead.
Acked-by: Jeff Layton <jlayton@samba.org>
Signed-off-by: Pavel Shilovsky <pshilovsky@samba.org>
Signed-off-by: Steve French <smfrench@gmail.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/file.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 643a18491bed..892a1e947b5a 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -2847,7 +2847,7 @@ cifs_uncached_read_into_pages(struct TCP_Server_Info *server, total_read += result; } - return total_read > 0 ? total_read : result; + return total_read > 0 && result != -EAGAIN ? total_read : result; } static ssize_t @@ -3270,7 +3270,7 @@ cifs_readpages_read_into_pages(struct TCP_Server_Info *server, total_read += result; } - return total_read > 0 ? total_read : result; + return total_read > 0 && result != -EAGAIN ? total_read : result; } static int cifs_readpages(struct file *file, struct address_space *mapping, |