diff options
| author | Suresh Jayaraman <sjayaraman@suse.de> | 2010-12-06 13:45:50 +0530 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2010-12-08 18:47:54 +0000 |
| commit | 545c988b2018a593f24d291b66776a0d08525acd (patch) | |
| tree | e2a0b2f523bf3c51e361c3735db359878e1d868f /fs/cifs | |
| parent | 7d161b7f41e24203b54b0f18ae0d26c18a6c6fab (diff) | |
| download | lwn-545c988b2018a593f24d291b66776a0d08525acd.tar.gz lwn-545c988b2018a593f24d291b66776a0d08525acd.zip | |
cifs: remove bogus remapping of error in cifs_filldir()
As the FIXME points out correctly, now filldir() itself returns -EOVERFLOW if
it not possible to represent the inode number supplied by the filesystem in
the field provided by userspace.
Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/readdir.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index 32d300e8f20e..a73eb9f4bdaf 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c @@ -759,18 +759,6 @@ static int cifs_filldir(char *pfindEntry, struct file *file, filldir_t filldir, rc = filldir(direntry, qstring.name, qstring.len, file->f_pos, ino, fattr.cf_dtype); - /* - * we can not return filldir errors to the caller since they are - * "normal" when the stat blocksize is too small - we return remapped - * error instead - * - * FIXME: This looks bogus. filldir returns -EOVERFLOW in the above - * case already. Why should we be clobbering other errors from it? - */ - if (rc) { - cFYI(1, "filldir rc = %d", rc); - rc = -EOVERFLOW; - } dput(tmp_dentry); return rc; } |