diff options
| author | Jeff Layton <jlayton@redhat.com> | 2011-06-20 14:33:16 -0400 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2011-06-24 17:03:55 +0000 |
| commit | e4fb0edb7c03e5ec19b6f732f1dfbe911212dbde (patch) | |
| tree | 1ac0749688ab9e90bdf486db591a24536f9eba86 /fs/cifs/smbencrypt.c | |
| parent | 5220cc9382e11ca955ce946ee6a5bac577bb14ff (diff) | |
| download | lwn-e4fb0edb7c03e5ec19b6f732f1dfbe911212dbde.tar.gz lwn-e4fb0edb7c03e5ec19b6f732f1dfbe911212dbde.zip | |
cifs: free blkcipher in smbhash
This is currently leaked in the rc == 0 case.
Reported-by: J. Bruce Fields <bfields@fieldses.org>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/smbencrypt.c')
| -rw-r--r-- | fs/cifs/smbencrypt.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c index 1525d5e662b6..1c5b770c3141 100644 --- a/fs/cifs/smbencrypt.c +++ b/fs/cifs/smbencrypt.c @@ -90,12 +90,10 @@ smbhash(unsigned char *out, const unsigned char *in, unsigned char *key) sg_init_one(&sgout, out, 8); rc = crypto_blkcipher_encrypt(&desc, &sgout, &sgin, 8); - if (rc) { + if (rc) cERROR(1, "could not encrypt crypt key rc: %d\n", rc); - crypto_free_blkcipher(tfm_des); - goto smbhash_err; - } + crypto_free_blkcipher(tfm_des); smbhash_err: return rc; } |