diff options
| author | Steve French <smfrench@gmail.com> | 2014-08-17 00:22:24 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-09-17 09:19:26 -0700 |
| commit | e6fc2f0c1df49edd76d34517133fab7fb93cd5cc (patch) | |
| tree | d527fcdfce3cf47a398ede23eac0f9480f91f65d /fs/cifs/smb2pdu.c | |
| parent | d97cad5311f722aefc9cb7b3bbf723b9e73c6598 (diff) | |
| download | lwn-e6fc2f0c1df49edd76d34517133fab7fb93cd5cc.tar.gz lwn-e6fc2f0c1df49edd76d34517133fab7fb93cd5cc.zip | |
CIFS: Possible null ptr deref in SMB2_tcon
commit 18f39e7be0121317550d03e267e3ebd4dbfbb3ce upstream.
As Raphael Geissert pointed out, tcon_error_exit can dereference tcon
and there is one path in which tcon can be null.
Signed-off-by: Steve French <smfrench@gmail.com>
Reported-by: Raphael Geissert <geissert@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/cifs/smb2pdu.c')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 049a3f2693ba..2f00b357e743 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -916,7 +916,8 @@ tcon_exit: tcon_error_exit: if (rsp->hdr.Status == STATUS_BAD_NETWORK_NAME) { cifs_dbg(VFS, "BAD_NETWORK_NAME: %s\n", tree); - tcon->bad_network_name = true; + if (tcon) + tcon->bad_network_name = true; } goto tcon_exit; } |