diff options
| author | Steve French <stfrench@microsoft.com> | 2021-06-19 16:19:09 -0500 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-06-20 21:28:17 -0500 |
| commit | e0ae8a9aaeed7262f349e025b2162e8a13cb58d9 (patch) | |
| tree | c4ca416c82ef90969b0bf4f86ac9a44766905663 /fs/cifs/smb2pdu.c | |
| parent | e39df24169a2ceb0d359eb3a05ff982711f2eb32 (diff) | |
| download | lwn-e0ae8a9aaeed7262f349e025b2162e8a13cb58d9.tar.gz lwn-e0ae8a9aaeed7262f349e025b2162e8a13cb58d9.zip | |
smb311: remove dead code for non compounded posix query info
Although we may need this in some cases in the future, remove the
currently unused, non-compounded version of POSIX query info,
SMB11_posix_query_info (instead smb311_posix_query_path_info is now
called e.g. when revalidating dentries or retrieving info for getattr)
Addresses-Coverity: 1495708 ("Resource leaks")
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/smb2pdu.c')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 0005989d281a..31784e3fa96f 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -3470,6 +3470,8 @@ int SMB2_query_info(const unsigned int xid, struct cifs_tcon *tcon, NULL); } +#if 0 +/* currently unused, as now we are doing compounding instead (see smb311_posix_query_path_info) */ int SMB311_posix_query_info(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, struct smb311_posix_qinfo *data, u32 *plen) @@ -3481,7 +3483,9 @@ SMB311_posix_query_info(const unsigned int xid, struct cifs_tcon *tcon, return query_info(xid, tcon, persistent_fid, volatile_fid, SMB_FIND_FILE_POSIX_INFO, SMB2_O_INFO_FILE, 0, output_len, sizeof(struct smb311_posix_qinfo), (void **)&data, plen); + /* Note caller must free "data" (passed in above). It may be allocated in query_info call */ } +#endif int SMB2_query_acl(const unsigned int xid, struct cifs_tcon *tcon, |