diff options
| author | Jim McDonough <jmcd@samba.org> | 2013-09-21 10:36:10 -0500 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2013-09-21 10:36:10 -0500 |
| commit | 74d290da476f672ad756634d12aa707375d3564d (patch) | |
| tree | aa972423ddb39e39d49cca13349eb9e07c3d70c3 /fs/cifs/readdir.c | |
| parent | 9ae6cf606a33b0a762798df0fb742848bcc685b5 (diff) | |
| download | lwn-74d290da476f672ad756634d12aa707375d3564d.tar.gz lwn-74d290da476f672ad756634d12aa707375d3564d.zip | |
[CIFS] Provide sane values for nlink
Since we don't get info about the number of links from the readdir
linfo levels, stat() will return 0 for st_nlink, and in particular,
samba re-exported shares will show directories as files (as samba is
keying off st_nlink before evaluating how to set the dos modebits)
when doing a dir or ls.
Copy nlink to the inode, unless it wasn't provided. Provide
sane values if we don't have an existing one and none was provided.
Signed-off-by: Jim McDonough <jmcd@samba.org>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/cifs/readdir.c')
| -rw-r--r-- | fs/cifs/readdir.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index 42ef03be089f..53a75f3d0179 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c @@ -180,6 +180,9 @@ cifs_fill_common_info(struct cifs_fattr *fattr, struct cifs_sb_info *cifs_sb) fattr->cf_dtype = DT_REG; } + /* non-unix readdir doesn't provide nlink */ + fattr->cf_flags |= CIFS_FATTR_UNKNOWN_NLINK; + if (fattr->cf_cifsattrs & ATTR_READONLY) fattr->cf_mode &= ~S_IWUGO; |