diff options
| author | Jeff Layton <jlayton@redhat.com> | 2011-01-11 07:24:02 -0500 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2011-01-19 17:52:38 +0000 |
| commit | 8097531a5cb55c6472118da094dc88caf9be66ac (patch) | |
| tree | 77707f0bc5fe63e08844426ffe878a0191f4faef /fs/cifs/connect.c | |
| parent | c5797a945cac4c470f0113fc839c521aab0d799d (diff) | |
| download | lwn-8097531a5cb55c6472118da094dc88caf9be66ac.tar.gz lwn-8097531a5cb55c6472118da094dc88caf9be66ac.zip | |
cifs: clean up accesses to midCount
It's an atomic_t and the code accesses the "counter" field in it directly
instead of using atomic_read(). It also is sometimes accessed under a
spinlock and sometimes not. Move it out of the spinlock since we don't need
belt-and-suspenders for something that's just informational.
Reviewed-by: Suresh Jayaraman <sjayaraman@suse.de>
Reviewed-by: Pavel Shilovsky <piastryyy@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/connect.c')
| -rw-r--r-- | fs/cifs/connect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 75b538f50b12..465ecad6d7cc 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -628,7 +628,7 @@ multi_t2_fnd: } else if (!is_valid_oplock_break(smb_buffer, server) && !isMultiRsp) { cERROR(1, "No task to wake, unknown frame received! " - "NumMids %d", midCount.counter); + "NumMids %d", atomic_read(&midCount)); cifs_dump_mem("Received Data is: ", (char *)smb_buffer, sizeof(struct smb_hdr)); #ifdef CONFIG_CIFS_DEBUG2 |