diff options
| author | Silviu-Mihai Popescu <silviupopescu1990@gmail.com> | 2013-03-11 18:22:32 +0200 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2013-05-04 22:08:19 -0500 |
| commit | f7f7c1850eb98da758731ea7edfa830ebefe24cd (patch) | |
| tree | 78e8199747533ec4b78e27fd739ea68ebf13a171 /fs/cifs/cifssmb.c | |
| parent | d455b72bdd23a1d7adcbdfb5c1ceabcd7beaf853 (diff) | |
| download | lwn-f7f7c1850eb98da758731ea7edfa830ebefe24cd.tar.gz lwn-f7f7c1850eb98da758731ea7edfa830ebefe24cd.zip | |
fs: cifs: use kmemdup instead of kmalloc + memcpy
This replaces calls to kmalloc followed by memcpy with a single call to
kmemdup. This was found via make coccicheck.
Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/cifs/cifssmb.c')
| -rw-r--r-- | fs/cifs/cifssmb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 8e2e799e7a24..1e7a4fe1f810 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -3742,12 +3742,11 @@ CIFSSMBGetCIFSACL(const unsigned int xid, struct cifs_tcon *tcon, __u16 fid, rc = -EINVAL; *pbuflen = 0; } else { - *acl_inf = kmalloc(*pbuflen, GFP_KERNEL); + *acl_inf = kmemdup(pdata, *pbuflen, GFP_KERNEL); if (*acl_inf == NULL) { *pbuflen = 0; rc = -ENOMEM; } - memcpy(*acl_inf, pdata, *pbuflen); } } qsec_out: |