diff options
| author | Steve French <smfrench@gmail.com> | 2012-08-03 09:42:45 -0500 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2012-08-19 22:30:13 -0500 |
| commit | 985e4ff016b5f3d95c12fe8073d1df89300dab3d (patch) | |
| tree | 5064073d2ad0f252fb7b0491c29a1a51cb83bdeb /fs/cifs/cifssmb.c | |
| parent | 7411286088d5ba879e9ffcaaa296f657642ef2c4 (diff) | |
| download | lwn-985e4ff016b5f3d95c12fe8073d1df89300dab3d.tar.gz lwn-985e4ff016b5f3d95c12fe8073d1df89300dab3d.zip | |
cifs: print error code if smb signature verification fails
While trying to debug a SMB signature related issue with Windows Servers
figured out it might be easier to debug if we print the error code from
cifs_verify_signature(). Also, fix indendation while at it.
Signed-off-by: Suresh Jayaraman <sjayaraman@suse.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/cifs/cifssmb.c')
| -rw-r--r-- | fs/cifs/cifssmb.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 074923ce593d..f0cf934ba877 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -1576,9 +1576,14 @@ cifs_readv_callback(struct mid_q_entry *mid) /* result already set, check signature */ if (server->sec_mode & (SECMODE_SIGN_REQUIRED | SECMODE_SIGN_ENABLED)) { - if (cifs_verify_signature(rdata->iov, rdata->nr_iov, - server, mid->sequence_number + 1)) - cERROR(1, "Unexpected SMB signature"); + int rc = 0; + + rc = cifs_verify_signature(rdata->iov, rdata->nr_iov, + server, + mid->sequence_number + 1); + if (rc) + cERROR(1, "SMB signature verification returned " + "error = %d", rc); } /* FIXME: should this be counted toward the initiating task? */ task_io_account_read(rdata->bytes); |