diff options
| author | Steve French <sfrench@us.ibm.com> | 2011-03-01 05:02:57 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2011-05-19 14:10:48 +0000 |
| commit | 34c87901e113799a45423fdac29c7478c889a95d (patch) | |
| tree | 1398028abbfc10d181f3a3c805c78ebb689d9e70 /fs/cifs/cifsglob.h | |
| parent | fd62cb7e7411f1f5ca774145665316d3612fed9a (diff) | |
| download | lwn-34c87901e113799a45423fdac29c7478c889a95d.tar.gz lwn-34c87901e113799a45423fdac29c7478c889a95d.zip | |
Shrink stack space usage in cifs_construct_tcon
We were reserving MAX_USERNAME (now 256) on stack for
something which only needs to fit about 24 bytes ie
string krb50x + printf version of uid
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/cifsglob.h')
| -rw-r--r-- | fs/cifs/cifsglob.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index 6e211b67b273..108a1e99aa9f 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h @@ -274,7 +274,8 @@ struct cifsSesInfo { int capabilities; char serverName[SERVER_NAME_LEN_WITH_NULL * 2]; /* BB make bigger for TCP names - will ipv6 and sctp addresses fit? */ - char *user_name; + char *user_name; /* must not be null except during init of sess + and after mount option parsing we fill it */ char *domainName; char *password; struct session_key auth_key; |