diff options
| author | Jeff Layton <jlayton@kernel.org> | 2021-03-26 09:21:53 -0400 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2021-04-27 23:52:23 +0200 |
| commit | 1775c7ddacfcea29051c67409087578f8f4d751b (patch) | |
| tree | 070dc51107b0bf6a85f00f1496422c4b4e76b6d6 /fs/ceph/export.c | |
| parent | e9b2250156c381b0973ea6ec3890fe8706426ecc (diff) | |
| download | lwn-1775c7ddacfcea29051c67409087578f8f4d751b.tar.gz lwn-1775c7ddacfcea29051c67409087578f8f4d751b.zip | |
ceph: fix inode leak on getattr error in __fh_to_dentry
Fixes: 878dabb64117 ("ceph: don't return -ESTALE if there's still an open file")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/ceph/export.c')
| -rw-r--r-- | fs/ceph/export.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ceph/export.c b/fs/ceph/export.c index e088843a7734..baa6368bece5 100644 --- a/fs/ceph/export.c +++ b/fs/ceph/export.c @@ -178,8 +178,10 @@ static struct dentry *__fh_to_dentry(struct super_block *sb, u64 ino) return ERR_CAST(inode); /* We need LINK caps to reliably check i_nlink */ err = ceph_do_getattr(inode, CEPH_CAP_LINK_SHARED, false); - if (err) + if (err) { + iput(inode); return ERR_PTR(err); + } /* -ESTALE if inode as been unlinked and no file is open */ if ((inode->i_nlink == 0) && (atomic_read(&inode->i_count) == 1)) { iput(inode); |