diff options
| author | Josef Bacik <jbacik@fusionio.com> | 2012-08-02 10:22:20 -0400 |
|---|---|---|
| committer | Chris Mason <chris.mason@oracle.com> | 2012-08-28 16:53:29 -0400 |
| commit | aa9ddcd4b5557102fa25695c11904f249b4dec49 (patch) | |
| tree | 5ed695e48b6d32fd45e582496edc1b3da6f3b5f0 /fs/btrfs | |
| parent | 3627bf4503b504077332c13496cb1bd54713bcbb (diff) | |
| download | lwn-aa9ddcd4b5557102fa25695c11904f249b4dec49.tar.gz lwn-aa9ddcd4b5557102fa25695c11904f249b4dec49.zip | |
Btrfs: do not use missing devices when showing devname
If you do the following
mkfs.btrfs /dev/sdb /dev/sdc
rmmod btrfs
dd if=/dev/zero of=/dev/sdb bs=1M count=1
mount -o degraded /dev/sdc /mnt/btrfs-test
the box will panic trying to deref the name for the missing dev since it is
the lower numbered devid. So fix show_devname to not use missing devices.
Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/super.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 75ee2c7791f0..2e06f124f284 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -1505,6 +1505,8 @@ static int btrfs_show_devname(struct seq_file *m, struct dentry *root) while (cur_devices) { head = &cur_devices->devices; list_for_each_entry(dev, head, dev_list) { + if (dev->missing) + continue; if (!first_dev || dev->devid < first_dev->devid) first_dev = dev; } |