diff options
| author | Anand Jain <anand.jain@oracle.com> | 2020-04-28 23:22:25 +0800 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2020-05-25 11:25:27 +0200 |
| commit | 1ed802c972c6c676412e34d168e313a17c3d931e (patch) | |
| tree | 43c511c24fd6bf02f3febe41fb21296f9115e435 /fs/btrfs/volumes.c | |
| parent | 0bc2d3c08e2b970117cc2b7c529291123978cae6 (diff) | |
| download | lwn-1ed802c972c6c676412e34d168e313a17c3d931e.tar.gz lwn-1ed802c972c6c676412e34d168e313a17c3d931e.zip | |
btrfs: drop useless goto in open_fs_devices
There is no need of goto out in open_fs_devices() as there is nothing
special done there.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/volumes.c')
| -rw-r--r-- | fs/btrfs/volumes.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index aa1e0ae32943..bf953c4895f3 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1185,7 +1185,6 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices, { struct btrfs_device *device; struct btrfs_device *latest_dev = NULL; - int ret = 0; flags |= FMODE_EXCL; @@ -1198,16 +1197,15 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices, device->generation > latest_dev->generation) latest_dev = device; } - if (fs_devices->open_devices == 0) { - ret = -EINVAL; - goto out; - } + if (fs_devices->open_devices == 0) + return -EINVAL; + fs_devices->opened = 1; fs_devices->latest_bdev = latest_dev->bdev; fs_devices->total_rw_bytes = 0; fs_devices->chunk_alloc_policy = BTRFS_CHUNK_ALLOC_REGULAR; -out: - return ret; + + return 0; } static int devid_cmp(void *priv, struct list_head *a, struct list_head *b) |