diff options
author | Josef Bacik <josef@toxicpanda.com> | 2020-10-23 09:58:04 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2020-12-08 15:54:02 +0100 |
commit | 9076dbd5ee837c3882fc42891c14cecd0354a849 (patch) | |
tree | 17fcaa377b1a8fc6cd7426ee6f0730624deb350e /fs/btrfs/transaction.c | |
parent | dc516164869300efd0bdbf6f894defc306588b75 (diff) | |
download | lwn-9076dbd5ee837c3882fc42891c14cecd0354a849.tar.gz lwn-9076dbd5ee837c3882fc42891c14cecd0354a849.zip |
btrfs: do not shorten unpin len for caching block groups
While fixing up our ->last_byte_to_unpin locking I noticed that we will
shorten len based on ->last_byte_to_unpin if we're caching when we're
adding back the free space. This is correct for the free space, as we
cannot unpin more than ->last_byte_to_unpin, however we use len to
adjust the ->bytes_pinned counters and such, which need to track the
actual pinned usage. This could result in
WARN_ON(space_info->bytes_pinned) triggering at unmount time.
Fix this by using a local variable for the amount to add to free space
cache, and leave len untouched in this case.
CC: stable@vger.kernel.org # 5.4+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/transaction.c')
0 files changed, 0 insertions, 0 deletions