diff options
author | Johannes Thumshirn <jth@kernel.org> | 2019-12-05 14:19:59 +0100 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2020-01-20 16:40:53 +0100 |
commit | b38f4cbd65fb56180f8d283f410ddec3965c93bf (patch) | |
tree | 81e1ed323a44b1b3b85b6910e526e7c0630e34bd /fs/btrfs/inode.c | |
parent | 129699522581f465e0300a286ed28a0aab0893d3 (diff) | |
download | lwn-b38f4cbd65fb56180f8d283f410ddec3965c93bf.tar.gz lwn-b38f4cbd65fb56180f8d283f410ddec3965c93bf.zip |
btrfs: remove impossible WARN_ON in btrfs_destroy_dev_replace_tgtdev()
We have a user report, that cppcheck is complaining about a possible
NULL-pointer dereference in btrfs_destroy_dev_replace_tgtdev().
We're first dereferencing the 'tgtdev' variable and the later check for
the validity of the pointer with a WARN_ON(!tgtdev);
But all callers of btrfs_destroy_dev_replace_tgtdev() either explicitly
check if 'tgtdev' is non-NULL or directly allocate 'tgtdev', so the
WARN_ON() is impossible to hit. Just remove it to silence the checker's
complains.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=205003
Signed-off-by: Johannes Thumshirn <jth@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/inode.c')
0 files changed, 0 insertions, 0 deletions