diff options
| author | Christoph Hellwig <hch@lst.de> | 2022-04-15 16:33:28 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2022-05-16 17:03:14 +0200 |
| commit | ad357938c6b4802c6f1f87c9a7811a33e240fa22 (patch) | |
| tree | 7a93d026918b0b90315b6fc43b567e36ee5fceeb /fs/btrfs/extent_io.h | |
| parent | cb4411dd571c855fa593e308fc8348554831d078 (diff) | |
| download | lwn-ad357938c6b4802c6f1f87c9a7811a33e240fa22.tar.gz lwn-ad357938c6b4802c6f1f87c9a7811a33e240fa22.zip | |
btrfs: do not return errors from submit_bio_hook_t instances
Both btrfs_repair_one_sector and submit_bio_one as the direct caller of
one of the instances ignore errors as they expect the methods themselves
to call ->bi_end_io on error. Remove the unused and dangerous return
value.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/extent_io.h')
| -rw-r--r-- | fs/btrfs/extent_io.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/extent_io.h b/fs/btrfs/extent_io.h index c94df8e2ab9d..b390ec79f9a8 100644 --- a/fs/btrfs/extent_io.h +++ b/fs/btrfs/extent_io.h @@ -71,7 +71,7 @@ struct btrfs_fs_info; struct io_failure_record; struct extent_io_tree; -typedef blk_status_t (submit_bio_hook_t)(struct inode *inode, struct bio *bio, +typedef void (submit_bio_hook_t)(struct inode *inode, struct bio *bio, int mirror_num, unsigned long bio_flags); |