diff options
| author | Matthew Wilcox (Oracle) <willy@infradead.org> | 2024-04-20 03:49:59 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-05-07 21:31:11 +0200 |
| commit | bc00965dbff7a8612c8ec0005b3bc943d7196629 (patch) | |
| tree | d00e70026cbd52e3aceb9ae483ffa30937a218bf /fs/btrfs/extent_io.c | |
| parent | 617fb10ea838f48c88c7f010eb68d150350914c8 (diff) | |
| download | lwn-bc00965dbff7a8612c8ec0005b3bc943d7196629.tar.gz lwn-bc00965dbff7a8612c8ec0005b3bc943d7196629.zip | |
btrfs: count super block write errors in device instead of tracking folio error state
Currently the error status of super block write is tracked in page/folio
status bit Error. For that we need to keep the reference for the whole
duration of write and wait.
Count the number of superblock writeback errors in the btrfs_device.
That means we don't need the folio to stay around until it's waited for,
and can avoid the extra call to folio_get/put.
Also remove a mention of PageError in a comment as it's the last mention
of the page Error state.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/extent_io.c')
| -rw-r--r-- | fs/btrfs/extent_io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 47a5bb95a994..597387e9f040 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -1602,7 +1602,7 @@ static void set_btree_ioerr(struct extent_buffer *eb) * can be no longer dirty nor marked anymore for writeback (if a * subsequent modification to the extent buffer didn't happen before the * transaction commit), which makes filemap_fdata[write|wait]_range not - * able to find the pages tagged with SetPageError at transaction + * able to find the pages which contain errors at transaction * commit time. So if this happens we must abort the transaction, * otherwise we commit a super block with btree roots that point to * btree nodes/leafs whose content on disk is invalid - either garbage |