diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2022-11-18 15:06:09 -0500 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2022-12-05 18:00:59 +0100 |
| commit | d7c9e1be2876f63fb2178a24e0c1d5733ff98d47 (patch) | |
| tree | ff1b5e3d1d7c77c9be741372dcf083c25e05f2de /fs/btrfs/extent-io-tree.c | |
| parent | a4c853af0c511d7e0f7cb306bbc8a4f1dbdb64ca (diff) | |
| download | lwn-d7c9e1be2876f63fb2178a24e0c1d5733ff98d47.tar.gz lwn-d7c9e1be2876f63fb2178a24e0c1d5733ff98d47.zip | |
btrfs: fix uninitialized parent in insert_state
I don't know how this isn't caught when we build this in the kernel, but
while syncing extent-io-tree.c into btrfs-progs I got an error because
parent could potentially be uninitialized when we link in a new node,
specifically when the extent_io_tree is empty. This means we could have
garbage in the parent color. I don't know what the ramifications are of
that, but it's probably not great, so fix this by initializing parent to
NULL. I spot checked all of our other usages in btrfs and we appear to
be doing the correct thing everywhere else.
Fixes: c7e118cf98c7 ("btrfs: open code rbtree search in insert_state")
CC: stable@vger.kernel.org # 6.0+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/extent-io-tree.c')
| -rw-r--r-- | fs/btrfs/extent-io-tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/extent-io-tree.c b/fs/btrfs/extent-io-tree.c index 21fa15123af8..82ca6a11e11a 100644 --- a/fs/btrfs/extent-io-tree.c +++ b/fs/btrfs/extent-io-tree.c @@ -395,7 +395,7 @@ static int insert_state(struct extent_io_tree *tree, u32 bits, struct extent_changeset *changeset) { struct rb_node **node; - struct rb_node *parent; + struct rb_node *parent = NULL; const u64 end = state->end; set_state_bits(tree, state, bits, changeset); |