diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-02-22 22:53:20 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2016-02-23 12:42:46 +0100 |
| commit | f827ba9a641b481f01d1bdc0771a7afc3776cc0b (patch) | |
| tree | 22ec5eb60e8b2210d3458b2565e1189ce8e89acd /fs/btrfs/disk-io.c | |
| parent | 5598e9005a4076d6700bbd89d0cdbe5b2922a846 (diff) | |
| download | lwn-f827ba9a641b481f01d1bdc0771a7afc3776cc0b.tar.gz lwn-f827ba9a641b481f01d1bdc0771a7afc3776cc0b.zip | |
btrfs: avoid uninitialized variable warning
With CONFIG_SMP and CONFIG_PREEMPT both disabled, gcc decides
to partially inline the get_state_failrec() function but cannot
figure out that means the failrec pointer is always valid
if the function returns success, which causes a harmless
warning:
fs/btrfs/extent_io.c: In function 'clean_io_failure':
fs/btrfs/extent_io.c:2131:4: error: 'failrec' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This marks get_state_failrec() and set_state_failrec() both
as 'noinline', which avoids the warning in all cases for me,
and seems less ugly than adding a fake initialization.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 47dc196ae719 ("btrfs: use proper type for failrec in extent_state")
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/disk-io.c')
0 files changed, 0 insertions, 0 deletions