diff options
| author | Filipe Manana <fdmanana@suse.com> | 2021-02-04 14:35:44 +0000 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2021-02-08 22:59:04 +0100 |
| commit | 72c9925f87c8b74f36f8e75a4cd93d964538d3ca (patch) | |
| tree | 26882a36fd7ca6502ef0df88b5f72f4e3803d5cf /fs/btrfs/ctree.c | |
| parent | 2c4d8cb737b805ca8d890e50c23f2b5eca270733 (diff) | |
| download | lwn-72c9925f87c8b74f36f8e75a4cd93d964538d3ca.tar.gz lwn-72c9925f87c8b74f36f8e75a4cd93d964538d3ca.zip | |
btrfs: fix extent buffer leak on failure to copy root
At btrfs_copy_root(), if the call to btrfs_inc_ref() fails we end up
returning without unlocking and releasing our reference on the extent
buffer named "cow" we previously allocated with btrfs_alloc_tree_block().
So fix that by unlocking the extent buffer and dropping our reference on
it before returning.
Fixes: be20aa9dbadc8c ("Btrfs: Add mount option to turn off data cow")
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ctree.c')
| -rw-r--r-- | fs/btrfs/ctree.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 95d9bae764ab..d56730a67885 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -222,6 +222,8 @@ int btrfs_copy_root(struct btrfs_trans_handle *trans, else ret = btrfs_inc_ref(trans, root, cow, 0); if (ret) { + btrfs_tree_unlock(cow); + free_extent_buffer(cow); btrfs_abort_transaction(trans, ret); return ret; } |