diff options
| author | David Sterba <dsterba@suse.com> | 2019-03-27 16:19:55 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2019-09-09 14:59:00 +0200 |
| commit | 73e82fe4099bbf3e06a351430bd4ed9703212dda (patch) | |
| tree | bd3545f712918d0e1382c66aaf14a2066a8d6c49 /fs/btrfs/ctree.c | |
| parent | d23ea3fa7dcb0d4a2c405de0879bc4ddcf521d7d (diff) | |
| download | lwn-73e82fe4099bbf3e06a351430bd4ed9703212dda.tar.gz lwn-73e82fe4099bbf3e06a351430bd4ed9703212dda.zip | |
btrfs: assert tree mod log lock in __tree_mod_log_insert
The tree is going to be modified so it must be the exclusive lock.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ctree.c')
| -rw-r--r-- | fs/btrfs/ctree.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 5df76c17775a..9d1d0a926cb0 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -376,8 +376,6 @@ void btrfs_put_tree_mod_seq(struct btrfs_fs_info *fs_info, * The 'start address' is the logical address of the *new* root node * for root replace operations, or the logical address of the affected * block for all other operations. - * - * Note: must be called with write lock for fs_info::tree_mod_log_lock. */ static noinline int __tree_mod_log_insert(struct btrfs_fs_info *fs_info, struct tree_mod_elem *tm) @@ -387,6 +385,8 @@ __tree_mod_log_insert(struct btrfs_fs_info *fs_info, struct tree_mod_elem *tm) struct rb_node *parent = NULL; struct tree_mod_elem *cur; + lockdep_assert_held_write(&fs_info->tree_mod_log_lock); + tm->seq = btrfs_inc_tree_mod_seq(fs_info); tm_root = &fs_info->tree_mod_log; |