diff options
author | Josef Bacik <josef@redhat.com> | 2011-07-24 15:45:34 -0400 |
---|---|---|
committer | Chris Mason <chris.mason@oracle.com> | 2011-07-27 12:46:46 -0400 |
commit | 81317fdeddcef259b6ecf7b5c0d04caa167c6b54 (patch) | |
tree | aeca005b8b595539b554a6b8a92dc052ccad5601 /fs/btrfs/ctree.c | |
parent | a65917156e345946dbde3d7effd28124c6d6a8c2 (diff) | |
download | lwn-81317fdeddcef259b6ecf7b5c0d04caa167c6b54.tar.gz lwn-81317fdeddcef259b6ecf7b5c0d04caa167c6b54.zip |
Btrfs: fix deadlock when throttling transactions
Hit this nice little deadlock. What happens is this
__btrfs_end_transaction with throttle set, --use_count so it equals 0
btrfs_commit_transaction
<somebody else actually manages to start the commit>
btrfs_end_transaction --use_count so now its -1 <== BAD
we just return and wait on the transaction
This is bad because we just return after our use_count is -1 and don't let go
of our num_writer count on the transaction, so the guy committing the
transaction just sits there forever. Fix this by inc'ing our use_count if we're
going to call commit_transaction so that if we call btrfs_end_transaction it's
valid. Thanks,
Signed-off-by: Josef Bacik <josef@redhat.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/btrfs/ctree.c')
0 files changed, 0 insertions, 0 deletions