diff options
author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-09-14 12:47:44 +0300 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:10:14 -0400 |
commit | 867c1fe0187f6df4dca84a34332e00f21ef80f69 (patch) | |
tree | ddc4595495f076ad108b98941e59ec0a86ebb2aa /fs/bcachefs/super.c | |
parent | 4ba985b84de627ba4f257c9843d0dd7146df2180 (diff) | |
download | lwn-867c1fe0187f6df4dca84a34332e00f21ef80f69.tar.gz lwn-867c1fe0187f6df4dca84a34332e00f21ef80f69.zip |
bcachefs: fix error checking in bch2_fs_alloc()
There is a typo here where it uses ";" instead of "?:". The result is
that bch2_fs_fs_io_direct_init() is called unconditionally and the errors
from it are not checked.
Fixes: 0060c68159fc ("bcachefs: Split up fs-io.[ch]")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Diffstat (limited to 'fs/bcachefs/super.c')
-rw-r--r-- | fs/bcachefs/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c index 2990eed85adf..e94a63a22704 100644 --- a/fs/bcachefs/super.c +++ b/fs/bcachefs/super.c @@ -852,7 +852,7 @@ static struct bch_fs *bch2_fs_alloc(struct bch_sb *sb, struct bch_opts opts) bch2_fs_compress_init(c) ?: bch2_fs_ec_init(c) ?: bch2_fs_fsio_init(c) ?: - bch2_fs_fs_io_buffered_init(c); + bch2_fs_fs_io_buffered_init(c) ?: bch2_fs_fs_io_direct_init(c); if (ret) goto err; |