diff options
author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-07-09 15:13:30 -0400 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:10:06 -0400 |
commit | 30a8278a1e2f627b1f28ab521e40eecacb223efc (patch) | |
tree | 0819826f0b4a4f140b0614bccc4a962f06a3824f /fs/bcachefs/btree_key_cache.c | |
parent | 07f293c8630d5bdae1615e6add90c76fed333d20 (diff) | |
download | lwn-30a8278a1e2f627b1f28ab521e40eecacb223efc.tar.gz lwn-30a8278a1e2f627b1f28ab521e40eecacb223efc.zip |
bcachefs: Add new assertions for shutdown path
We've been seeing assertions pop that indicate the btree node cache or
key cache have dirty items when we just did a clean shutdown.
Add some more assertions so we can catch this when we're dirtying items.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/btree_key_cache.c')
-rw-r--r-- | fs/bcachefs/btree_key_cache.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/bcachefs/btree_key_cache.c b/fs/bcachefs/btree_key_cache.c index 1d702efaf074..34d959c4e640 100644 --- a/fs/bcachefs/btree_key_cache.c +++ b/fs/bcachefs/btree_key_cache.c @@ -780,6 +780,7 @@ bool bch2_btree_insert_key_cached(struct btree_trans *trans, ck->valid = true; if (!test_bit(BKEY_CACHED_DIRTY, &ck->flags)) { + EBUG_ON(test_bit(BCH_FS_CLEAN_SHUTDOWN, &c->flags)); set_bit(BKEY_CACHED_DIRTY, &ck->flags); atomic_long_inc(&c->btree_key_cache.nr_dirty); |