diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2021-10-19 15:08:00 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:14 -0400 |
| commit | 9a796fdb06b56a1811f1afdd40b793e2848a990e (patch) | |
| tree | 0aff8322804e52e2eb7f078bb0688a5d2fda4462 /fs/bcachefs/btree_iter.c | |
| parent | d355c6f4f73060c8f3eba95b9ae72929669f7516 (diff) | |
| download | lwn-9a796fdb06b56a1811f1afdd40b793e2848a990e.tar.gz lwn-9a796fdb06b56a1811f1afdd40b793e2848a990e.zip | |
bcachefs: bch2_trans_exit() no longer returns errors
Now that peek_node()/next_node() are converted to return errors
directly, we don't need bch2_trans_exit() to return errors - it's
cleaner this way and wasn't used much anymore.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/btree_iter.c')
| -rw-r--r-- | fs/bcachefs/btree_iter.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c index 339b3657683a..25ed4f2ce19c 100644 --- a/fs/bcachefs/btree_iter.c +++ b/fs/bcachefs/btree_iter.c @@ -1346,10 +1346,8 @@ retry_all: } while (ret); } - if (unlikely(ret == -EIO)) { - trans->error = true; + if (unlikely(ret == -EIO)) goto out; - } BUG_ON(ret && ret != -EINTR); @@ -2781,7 +2779,7 @@ leaked: #endif } -int bch2_trans_exit(struct btree_trans *trans) +void bch2_trans_exit(struct btree_trans *trans) __releases(&c->btree_trans_barrier) { struct btree_insert_entry *i; @@ -2831,8 +2829,6 @@ int bch2_trans_exit(struct btree_trans *trans) trans->mem = (void *) 0x1; trans->paths = (void *) 0x1; - - return trans->error ? -EIO : 0; } static void __maybe_unused |