diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-09-04 14:09:15 +0300 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-09-08 13:56:42 -0700 |
| commit | c47ca32d3aadb234f73389a34c97574085bc9eda (patch) | |
| tree | c53ea33e0067560a26f0122b0b606cc5743b8acc /fs/attr.c | |
| parent | dac5705cad20070a70bb028ca52e1f0bc157b42d (diff) | |
| download | lwn-c47ca32d3aadb234f73389a34c97574085bc9eda.tar.gz lwn-c47ca32d3aadb234f73389a34c97574085bc9eda.zip | |
Btrfs: kfree()ing ERR_PTRs
The "inherit" in btrfs_ioctl_snap_create_v2() and "vol_args" in
btrfs_ioctl_rm_dev() are ERR_PTRs so we can't call kfree() on them.
These kind of bugs are "One Err Bugs" where there is just one error
label that does everything. I could set the "inherit = NULL" and keep
the single out label but it ends up being more complicated that way. It
makes the code simpler to re-order the unwind so it's in the mirror
order of the allocation and introduce some new error labels.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/attr.c')
0 files changed, 0 insertions, 0 deletions