diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2008-02-08 04:20:15 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-08 09:22:33 -0800 |
| commit | c2ec66828fd253802abb912668f4bf9597e3c898 (patch) | |
| tree | 6d7dfe34b423b5bf32a5a5ae6b35207db4bb5d22 /fs/aio.c | |
| parent | 7adfa2ff3efa02a7a9f2632d2d2662d3e5eb5304 (diff) | |
| download | lwn-c2ec66828fd253802abb912668f4bf9597e3c898.tar.gz lwn-c2ec66828fd253802abb912668f4bf9597e3c898.zip | |
aio: negative offset should return -EINVAL
An AIO read or write should return -EINVAL if the offset is negative.
This check matches the one in pread and pwrite.
This was found by the libaio test suite.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/aio.c')
| -rw-r--r-- | fs/aio.c | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -1329,6 +1329,10 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb) opcode = IOCB_CMD_PWRITEV; } + /* This matches the pread()/pwrite() logic */ + if (iocb->ki_pos < 0) + return -EINVAL; + do { ret = rw_op(iocb, &iocb->ki_iovec[iocb->ki_cur_seg], iocb->ki_nr_segs - iocb->ki_cur_seg, |