diff options
| author | Matthew Wilcox (Oracle) <willy@infradead.org> | 2021-03-20 05:40:40 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2021-03-23 20:54:37 +0000 |
| commit | 75b69799610c2b909a18e709c402923ea61aedc0 (patch) | |
| tree | a97cef12b7f4e828a8047b9398198aba52040189 /fs/afs | |
| parent | e5dbd33218bd8d87ab69f730ab90aed5fab7eb26 (diff) | |
| download | lwn-75b69799610c2b909a18e709c402923ea61aedc0.tar.gz lwn-75b69799610c2b909a18e709c402923ea61aedc0.zip | |
afs: Use wait_on_page_writeback_killable
Open-coding this function meant it missed out on the recent bugfix
for waiters being woken by a delayed wake event from a previous
instantiation of the page[1].
[DH: Changed the patch to use vmf->page rather than variable page which
doesn't exist yet upstream]
Fixes: 1cf7a1518aef ("afs: Implement shared-writeable mmap")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: kafs-testing@auristor.com
cc: linux-afs@lists.infradead.org
cc: linux-mm@kvack.org
Link: https://lore.kernel.org/r/20210320054104.1300774-4-willy@infradead.org
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c2407cf7d22d0c0d94cf20342b3b8f06f1d904e7 [1]
Diffstat (limited to 'fs/afs')
| -rw-r--r-- | fs/afs/write.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/afs/write.c b/fs/afs/write.c index c9195fc67fd8..eb737ed63afb 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c @@ -851,8 +851,7 @@ vm_fault_t afs_page_mkwrite(struct vm_fault *vmf) fscache_wait_on_page_write(vnode->cache, vmf->page); #endif - if (PageWriteback(vmf->page) && - wait_on_page_bit_killable(vmf->page, PG_writeback) < 0) + if (wait_on_page_writeback_killable(vmf->page)) return VM_FAULT_RETRY; if (lock_page_killable(vmf->page) < 0) |