diff options
| author | Dominique Martinet <dominique.martinet@cea.fr> | 2018-09-08 00:10:57 +0900 |
|---|---|---|
| committer | Dominique Martinet <dominique.martinet@cea.fr> | 2018-09-08 01:51:50 +0900 |
| commit | e02a53d92e197706cad1627bd84705d4aa20a145 (patch) | |
| tree | 9c9ccc69c27cf9ee8e9331d50ae6bc0640613378 /fs/9p | |
| parent | 5e172f75e51e3de1b4274146d9b990f803cb5c2a (diff) | |
| download | lwn-e02a53d92e197706cad1627bd84705d4aa20a145.tar.gz lwn-e02a53d92e197706cad1627bd84705d4aa20a145.zip | |
9p: acl: fix uninitialized iattr access
iattr is passed to v9fs_vfs_setattr_dotl which does send various
values from iattr over the wire, even if it tells the server to
only look at iattr.ia_valid fields this could leak some stack data.
Link: http://lkml.kernel.org/r/1536339057-21974-2-git-send-email-asmadeus@codewreck.org
Addresses-Coverity-ID: 1195601 ("Uninitalized scalar variable")
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Diffstat (limited to 'fs/9p')
| -rw-r--r-- | fs/9p/acl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/9p/acl.c b/fs/9p/acl.c index 082d227fa56b..6261719f6f2a 100644 --- a/fs/9p/acl.c +++ b/fs/9p/acl.c @@ -276,7 +276,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, switch (handler->flags) { case ACL_TYPE_ACCESS: if (acl) { - struct iattr iattr; + struct iattr iattr = { 0 }; struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl); |