summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorZev Weiss <zev@bewilderbeest.net>2023-08-10 21:59:41 +0930
committerArnd Bergmann <arnd@arndb.de>2023-08-12 12:12:34 +0200
commite4ad279ae345413d900d791f2f618d0a1cd0d791 (patch)
tree430efbb4d810f1d586cd4593345a05851f44f81f /drivers
parent42ff49a1967af71772b264009659ce181f7d2d2a (diff)
downloadlwn-e4ad279ae345413d900d791f2f618d0a1cd0d791.tar.gz
lwn-e4ad279ae345413d900d791f2f618d0a1cd0d791.zip
soc: aspeed: uart-routing: Use __sysfs_match_string
The existing use of match_string() caused it to reject 'echo foo' due to the implicitly appended newline, which was somewhat ergonomically awkward and inconsistent with typical sysfs behavior. Using the __sysfs_* variant instead provides more convenient and consistent linefeed-agnostic behavior. Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Fixes: c6807970c3bc ("soc: aspeed: Add UART routing support") Reviewed-by: Joel Stanley <joel@jms.id.au> Link: https://lore.kernel.org/r/20230628083735.19946-2-zev@bewilderbeest.net Signed-off-by: Joel Stanley <joel@jms.id.au> Link: https://lore.kernel.org/r/20230810122941.231085-1-joel@jms.id.au Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/soc/aspeed/aspeed-uart-routing.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soc/aspeed/aspeed-uart-routing.c b/drivers/soc/aspeed/aspeed-uart-routing.c
index ef8b24fd1851..59123e1f27ac 100644
--- a/drivers/soc/aspeed/aspeed-uart-routing.c
+++ b/drivers/soc/aspeed/aspeed-uart-routing.c
@@ -524,7 +524,7 @@ static ssize_t aspeed_uart_routing_store(struct device *dev,
struct aspeed_uart_routing_selector *sel = to_routing_selector(attr);
int val;
- val = match_string(sel->options, -1, buf);
+ val = __sysfs_match_string(sel->options, -1, buf);
if (val < 0) {
dev_err(dev, "invalid value \"%s\"\n", buf);
return -EINVAL;