diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-01-08 13:07:54 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-01-28 16:00:24 +0000 |
| commit | bef8c5fdf50b573351571e94525800c41d9830f2 (patch) | |
| tree | b022b345631c0dc28156eb48608db53b21e56843 /drivers | |
| parent | fa183433bf53ee092323005f05cb3491e4aaaa8b (diff) | |
| download | lwn-bef8c5fdf50b573351571e94525800c41d9830f2.tar.gz lwn-bef8c5fdf50b573351571e94525800c41d9830f2.zip | |
spi: qcom: geni: Simplify DMA setting
As stated in [1], dma_set_mask() with a 64-bit mask will never fail if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
Simplify code and remove some dead code accordingly.
[1]: https://lkml.org/lkml/2021/6/7/398
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/1b14e4ce91a33c16b2c655389c728071a9c9aa2e.1641643601.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/spi/spi-geni-qcom.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index f7d905d2a90f..4e83cc5b445d 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -898,11 +898,8 @@ static int spi_geni_probe(struct platform_device *pdev) return irq; ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); - if (ret) { - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); - if (ret) - return dev_err_probe(dev, ret, "could not set DMA mask\n"); - } + if (ret) + return dev_err_probe(dev, ret, "could not set DMA mask\n"); base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) |