diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2012-10-02 17:25:47 +0200 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2012-10-09 11:23:28 +0100 |
| commit | 9da5f5ac6affad8dd8cd80f5cca26e4335e1728b (patch) | |
| tree | 7c7b94c39e1b932feaf60ee1ae6e2fad1d5d4a39 /drivers | |
| parent | 2e9c9dfde00a6466441e93033cf2c37f720bdacf (diff) | |
| download | lwn-9da5f5ac6affad8dd8cd80f5cca26e4335e1728b.tar.gz lwn-9da5f5ac6affad8dd8cd80f5cca26e4335e1728b.zip | |
[SCSI] virtio-scsi: fix LUNs greater than 255
virtio-scsi needs to report LUNs greater than 256 using the "flat"
format. Because the Linux SCSI layer just maps the SCSI LUN to
an u32, without any parsing, these end up in the range from 16640
to 32767. Fix max_lun to account for the possibility that logical
unit numbers are encoded with the "flat" format.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/scsi/virtio_scsi.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 7554d7856434..a7cf726bc747 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -677,7 +677,11 @@ static int __devinit virtscsi_probe(struct virtio_device *vdev) cmd_per_lun = virtscsi_config_get(vdev, cmd_per_lun) ?: 1; shost->cmd_per_lun = min_t(u32, cmd_per_lun, shost->can_queue); shost->max_sectors = virtscsi_config_get(vdev, max_sectors) ?: 0xFFFF; - shost->max_lun = virtscsi_config_get(vdev, max_lun) + 1; + + /* LUNs > 256 are reported with format 1, so they go in the range + * 16640-32767. + */ + shost->max_lun = virtscsi_config_get(vdev, max_lun) + 1 + 0x4000; shost->max_id = num_targets; shost->max_channel = 0; shost->max_cmd_len = VIRTIO_SCSI_CDB_SIZE; |