summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorLi RongQing <lirongqing@baidu.com>2023-01-06 12:03:42 +0800
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2023-01-20 17:33:52 +0100
commit716ff71ae234fd3ef1286aac8d8a19a0ed2d509d (patch)
treefe372d50a3a26b56a17c65b84b507aa972b7ab5e /drivers
parent4edc13ae891ab368a3026cde1dbf263331bc6e77 (diff)
downloadlwn-716ff71ae234fd3ef1286aac8d8a19a0ed2d509d.tar.gz
lwn-716ff71ae234fd3ef1286aac8d8a19a0ed2d509d.zip
cpuidle-haltpoll: Replace default_idle() with arch_cpu_idle()
When a KVM guest has MWAIT, mwait_idle() is used as the default idle function. However, the cpuidle-haltpoll driver calls default_idle() from default_enter_idle() directly and that one uses HLT instead of MWAIT, which may affect performance adversely, because MWAIT is preferred to HLT as explained by the changelog of commit aebef63cf7ff ("x86: Remove vendor checks from prefer_mwait_c1_over_halt"). Make default_enter_idle() call arch_cpu_idle(), which can use MWAIT, instead of default_idle() to address this issue. Suggested-by: Thomas Gleixner <tglx@linutronix.de> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Li RongQing <lirongqing@baidu.com> [ rjw: Changelog rewrite ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/cpuidle/cpuidle-haltpoll.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c
index 3a39a7f48b77..e66df22f9695 100644
--- a/drivers/cpuidle/cpuidle-haltpoll.c
+++ b/drivers/cpuidle/cpuidle-haltpoll.c
@@ -32,7 +32,7 @@ static int default_enter_idle(struct cpuidle_device *dev,
local_irq_enable();
return index;
}
- default_idle();
+ arch_cpu_idle();
return index;
}